Unlock prerender #2928
Merged
Unlock prerender #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates core dependencies and implements BiDi-based handle management and input actions to enable prerender navigation support.
- Bumped the WebDriverBiDi package version to 0.0.15.
- Unified disposal logic for element handles and introduced BiDi handle injection/disown via
ScriptInjector. - Added BiDi pointer action support (
PerformActionsAsync,BidiMouse) and refined frame realm script injection.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/PuppeteerSharp/PuppeteerSharp.csproj | Upgraded WebDriverBiDi dependency to version 0.0.15 |
| lib/PuppeteerSharp/Helpers/DictionaryExtensions.cs | Added JSON and PuppeteerSharp.Helpers.Json imports |
| lib/PuppeteerSharp/ElementHandle.cs | Changed Handle visibility and implemented DisposeAsync |
| lib/PuppeteerSharp/Cdp/CdpElementHandle.cs | Removed duplicate DisposeAsync override |
| lib/PuppeteerSharp/Bidi/Core/Session.cs | Introduced ScriptInjector field for script injection |
| lib/PuppeteerSharp/Bidi/Core/Realm.cs | Added DisownAsync method for handle cleanup |
| lib/PuppeteerSharp/Bidi/Core/BrowsingContext.cs | Added PerformActionsAsync for pointer events |
| lib/PuppeteerSharp/Bidi/BidiRealm.cs | Implemented handle destruction, transfer, and serialization |
| lib/PuppeteerSharp/Bidi/BidiPage.cs | Initialized BidiMouse in page constructor |
| lib/PuppeteerSharp/Bidi/BidiMouse.cs | Implemented BiDi-based mouse actions |
| lib/PuppeteerSharp/Bidi/BidiJSHandle.cs | Implemented DisposeAsync and remote handle cleanup |
| lib/PuppeteerSharp/Bidi/BidiFrameRealm.cs | Refined script injection queue and reset logic |
| lib/PuppeteerSharp/Bidi/BidiElementHandle.cs | Adjusted realm/page properties |
| lib/PuppeteerSharp.Tests/PrerenderTests/PrerenderTests.cs | Removed stray whitespace |
| lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json | Standardized JSON formatting |
| lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json | Removed outdated local skips |
Comments suppressed due to low confidence (1)
lib/PuppeteerSharp/Bidi/BidiRealm.cs:324
- The type
LazyArgis undefined: the originalBidiLazyArgdelegate was removed but not replaced or imported. DefineLazyArgor revert toBidiLazyArgto fix the compilation error.
if (arg is LazyArg lazyArg)
# Conflicts: # lib/PuppeteerSharp/Cdp/CdpFrame.cs
# Conflicts: # lib/PuppeteerSharp/Bidi/BidiFrameRealm.cs # lib/PuppeteerSharp/Bidi/BidiJSHandle.cs # lib/PuppeteerSharp/Bidi/BidiRealm.cs # lib/PuppeteerSharp/PuppeteerSharp.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.